Repository navigation
fix: use BareBonesBrowserLaunch for Privacy Policy link on all platforms - #264
Merged
tonygermano merged 1 commit intoNov 7, 2026
Conversation
Contributor
|
@dowel015, this one also looks good, but needs a DCO. Please add. |
Contributor
|
Be carefull, commit come from claude AI, a licencing problem can appear |
dowel015
force-pushed
the
fix/privacy-policy-link-issue-86
branch
2 times, most recently
from
April 2, 2026 18:21
56212fc to
b1165d7
Compare
Desktop.getDesktop().browse() throws on some Linux platforms even when Desktop.isDesktopSupported() returns true, causing the Privacy Policy hyperlink in FirstLoginDialog to silently fail. Replace the Desktop if/else with a direct call to BareBonesBrowserLaunch.openURL() which works reliably cross-platform. Fixes OpenIntegrationEngine#86. Issue: OpenIntegrationEngine#86 Signed-off-by: Joshua Dowell <joshua.dowell@centrallogic.com> Signed-off-by: Tony Germano <tony@germano.name>
tonygermano
force-pushed
the
fix/privacy-policy-link-issue-86
branch
from
November 7, 2026 12:06
b1165d7 to
85bf679
Compare
tonygermano
requested review from
NicoPiel,
gibson9583,
jonbartels,
kayyagari,
kpalang,
ssrowe and
tonygermano
November 7, 2026 12:06
tonygermano
approved these changes
Nov 7, 2026
tonygermano
left a comment
tonygermano
left a comment
Member
There was a problem hiding this comment.
LGTM. Clean implementation of the fix described in #86 .
My recent force push:
- rebased to resolve conflict since the gradle source files move
- removed unused
java.awt.Desktopimport
mgaffigan
approved these changes
Nov 7, 2026
pacmano1
approved these changes
Nov 7, 2026
tonygermano
merged commit Nov 7, 2026
85bf679
into
OpenIntegrationEngine:main
11 of 12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Desktop.isDesktopSupported()returnstruebutDesktop.getDesktop().browse()throws an exception, causing the Privacy Policy hyperlink in the first login dialog to silently failDesktopAPI usage entirely from the hyperlink listenerBareBonesBrowserLaunch.openURL()directly, which works reliably cross-platformFixes #86
Test plan
🤖 Generated with Claude Code